-
Notifications
You must be signed in to change notification settings - Fork 11
fix(macOS): resolve build failures and deployment target issues #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
x15sr71
wants to merge
1
commit into
CCExtractor:main
Choose a base branch
from
x15sr71:macos-build-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey Chandragupt!
Thanks for this initiative! I currently don’t have access to my system!
Will review and reply on the PR in 1-2 days!
Thanks
…On Fri, 5 Sep 2025 at 8:21 PM, Chandragupt Singh ***@***.***> wrote:
Fixes critical macOS build failures that were preventing development on
modern macOS systems.
*Resolves:* #11
<#11>
------------------------------
Problem
- BUILD FAILED on macOS due to outdated deployment target (10.12)
- Missing CocoaPods integration causing framework linking errors
- Incompatibility with modern Xcode versions and Apple Silicon hardware
------------------------------
Solution Fixed Deployment Target
- Updated MACOSX_DEPLOYMENT_TARGET from *10.12 → 10.15*
- Ensures compatibility with modern SDKs and build tools
Added CocoaPods Integration
- Configured Xcode project with CocoaPods build phases and base
configurations
- Added workspace reference to Pods project for proper framework
linking
- Enables Firebase SDK dependencies to link correctly
Modernized Swift Code
- Updated AppDelegate.swift: replaced @NSApplicationMain → @main
- Implemented applicationSupportsSecureRestorableState for modern
lifecycle support
Updated Dependencies
- Upgraded flutter_local_notifications to *v19.4.1* for compatibility
- Added Windows plugin support for cross-platform consistency
------------------------------
Screenshots Click to view successful build & app launch Screenshot.2025-09-05.at.8.11.16.PM.png
(view on web)
<https://github.com/user-attachments/assets/f62fa4ed-d1f5-49ee-a6cd-17642397a084>
------------------------------
Environment Tested
- *macOS:* 15.6.1 (24G90)
- *Chip:* Apple M4 Pro (ARM64)
- *Xcode:* 16.4 (Build 16F6)
- *Flutter:* 3.35.2
- *CocoaPods:* 1.16.2
------------------------------
Testing
- Fresh clone → build succeeds on macOS
- flutter run -d macos launches app successfully
- Firebase SDK initializes without linking errors
- No CocoaPods warnings or mismatched deployment targets
------------------------------
Notes & Remaining Warnings
During testing, some *non-critical warnings* still appear from CocoaPods
build phases, e.g.:
warning: Run script build phase 'Create Symlinks to Header Folders' will
be run during every build because it does not specify any outputs.
These warnings come from Pods such as *abseil, BoringSSL-GRPC, gRPC-Core,
gRPC-C++*, etc.
These are *not critical to the purpose of this PR*, which is focused on
fixing the *macOS build failures*.
They can be safely addressed in a *future cleanup PR*.
- Changes are scoped only to *macOS build system + dependencies*
- No app logic or UI changes were introduced
- Safe for merge without affecting iOS/Android builds
------------------------------
👋 Hi, I’m Chandragupt, a new contributor to CCExtractor.
This PR is my first step towards improving macOS compatibility for the
firebase_editor project.
------------------------------
You can view, comment on, or merge this pull request online at:
#12
Commit Summary
- 49fd590
<49fd590>
fix(macos): resolve macOS build infrastructure issues
File Changes
(16 files
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files>)
- *M* .gitignore
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947>
(2)
- *M* ios/Flutter/Debug.xcconfig
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-db97fa909d57626a73c31dac2d84771359597c4932641a8a170087e8b8beb529>
(1)
- *M* ios/Flutter/Release.xcconfig
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-748ccd183dd22ed6f0a8dc5469e2975846964d38b015b39ed6c9d416383a22c9>
(1)
- *A* ios/Podfile
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-281ded35b124f5160d0a57e47e521ee6f49f233933e091a0d33f3fd42a74abc8>
(43)
- *M* lib/firebase_options.dart
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-04af3bb70a2c04101b0ab62cbba8f49cffdfaa374e802b63b4728a12f7fcbdab>
(19)
- *M* macos/Flutter/Flutter-Debug.xcconfig
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-d6092dfe1ec34d44b3639907e52f9ef886b03e8324a158c915422a0a0420f3bc>
(1)
- *M* macos/Flutter/Flutter-Release.xcconfig
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-b412b53b35cb1d383f2fed7735e93b80147214f423a6f431c4841b05461b2390>
(1)
- *A* macos/Podfile
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-f884afd426938fe6ea5d1b0089a5feddfc356659592f068b3b28cde8e7bbfd61>
(87)
- *A* macos/Podfile.lock
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-c040557dce7feadea382f3371962ee256cf2d504db3e0fcaceb8d0566a8db1ee>
(1278)
- *M* macos/Runner.xcodeproj/project.pbxproj
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-ec40d5406d2e5b54c265f64285bf1f073febb06b92a906239f8905a6244e68ef>
(126)
- *M* macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-37c8cacd6cbc248a150e965bc84310faaf27b50eb5dbd93a5cb05bc8b678ae91>
(1)
- *M* macos/Runner.xcworkspace/contents.xcworkspacedata
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-2f43198f2d5691d3ba692e9ebaf1896412afe938c714cde0b7d7cc6a47c91b46>
(3)
- *M* macos/Runner/AppDelegate.swift
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-4e85cf48a95329434dfcfb09f6ad53b620aee7342af0fe5ab93ac1a9087de023>
(6)
- *M* pubspec.lock
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-e125d55a387d4b24048735f9ca6508c4e860f5ca1f3242edfd9df27e7d8a7af0>
(90)
- *M* pubspec.yaml
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-8b7e9df87668ffa6a04b32e1769a33434999e54ae081c52e5d943c541d4c0d25>
(2)
- *M* windows/flutter/generated_plugins.cmake
<https://github.com/CCExtractor/firebase_editor_gsoc/pull/12/files#diff-4b55067a54dd3cd60674a36f6ce312785562c37d6eb38427e9801068b87c2297>
(1)
Patch Links:
- https://github.com/CCExtractor/firebase_editor_gsoc/pull/12.patch
- https://github.com/CCExtractor/firebase_editor_gsoc/pull/12.diff
—
Reply to this email directly, view it on GitHub
<#12>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWWLIHBP7QQEULW7YECAIAL3RGPOXAVCNFSM6AAAAACFXM4W4OVHI2DSMVQWIX3LMV43ASLTON2WKOZTGM4DOOBTGMZTMNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hey @chiragtyagi2003, Thanks for letting me know! |
Hello @chiragtyagi2003, just a gentle reminder regarding this PR. Your review when convenient would be much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes critical macOS build failures that were preventing development on modern macOS systems.
Resolves: #11
Problem
BUILD FAILED
on macOS due to outdated deployment target (10.12
)Solution
Fixed Deployment Target
MACOSX_DEPLOYMENT_TARGET
from 10.12 → 10.15Added CocoaPods Integration
Modernized Swift Code
AppDelegate.swift
: replaced@NSApplicationMain
→@main
applicationSupportsSecureRestorableState
for modern lifecycle supportUpdated Dependencies
flutter_local_notifications
to v19.4.1 for compatibilityScreenshots
Click to view successful build & app launch
Environment Tested
Testing
flutter run -d macos
launches app successfullyNotes & Remaining Warnings
During testing, some non-critical warnings still appear from CocoaPods build phases, e.g.:
These warnings come from Pods such as abseil, BoringSSL-GRPC, gRPC-Core, gRPC-C++, etc.
These are not critical to the purpose of this PR, which is focused on fixing the macOS build failures.
They can be safely addressed in a future cleanup PR.
👋 Hi, I’m Chandragupt, a new contributor to CCExtractor.
This PR is my first step towards improving macOS compatibility for the firebase_editor project.